lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0739/1039] ASoC: imx-hdmi: add put_device() after of_find_device_by_node()
    Date
    From: Ye Guojin <ye.guojin@zte.com.cn>

    [ Upstream commit f670b274f7f6f4b2722d7f08d0fddf606a727e92 ]

    This was found by coccicheck:
    ./sound/soc/fsl/imx-hdmi.c,209,1-7,ERROR missing put_device; call
    of_find_device_by_node on line 119, but without a corresponding object
    release within this function.

    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
    Link: https://lore.kernel.org/r/20211110002910.134915-1-ye.guojin@zte.com.cn
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/fsl/imx-hdmi.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c
    index f10359a288005..929f69b758af4 100644
    --- a/sound/soc/fsl/imx-hdmi.c
    +++ b/sound/soc/fsl/imx-hdmi.c
    @@ -145,6 +145,8 @@ static int imx_hdmi_probe(struct platform_device *pdev)
    data->dai.capture_only = false;
    data->dai.init = imx_hdmi_init;

    + put_device(&cpu_pdev->dev);
    +
    if (of_node_name_eq(cpu_np, "sai")) {
    data->cpu_priv.sysclk_id[1] = FSL_SAI_CLK_MAST1;
    data->cpu_priv.sysclk_id[0] = FSL_SAI_CLK_MAST1;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:14    [W:5.873 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site