lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0817/1039] drm/sun4i: dw-hdmi: Fix missing put_device() call in sun8i_hdmi_phy_get
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    [ Upstream commit c71af3dae3e34d2fde0c19623cf7f8483321f0e3 ]

    The reference taken by 'of_find_device_by_node()' must be released when
    not needed anymore.
    Add the corresponding 'put_device()' in the error handling path.

    Fixes: 9bf3797796f5 ("drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Link: https://patchwork.freedesktop.org/patch/msgid/20220107083633.20843-1-linmq006@gmail.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
    index b64d93da651d2..5e2b0175df36f 100644
    --- a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
    +++ b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
    @@ -658,8 +658,10 @@ int sun8i_hdmi_phy_get(struct sun8i_dw_hdmi *hdmi, struct device_node *node)
    return -EPROBE_DEFER;

    phy = platform_get_drvdata(pdev);
    - if (!phy)
    + if (!phy) {
    + put_device(&pdev->dev);
    return -EPROBE_DEFER;
    + }

    hdmi->phy = phy;

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:14    [W:4.023 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site