lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0825/1039] i3c: master: dw: check return of dw_i3c_master_get_free_pos()
    Date
    From: Tom Rix <trix@redhat.com>

    [ Upstream commit 13462ba1815db5a96891293a9cfaa2451f7bd623 ]

    Clang static analysis reports this problem
    dw-i3c-master.c:799:9: warning: The result of the left shift is
    undefined because the left operand is negative
    COMMAND_PORT_DEV_INDEX(pos) |
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~

    pos can be negative because dw_i3c_master_get_free_pos() can return an
    error. So check for an error.

    Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
    Signed-off-by: Tom Rix <trix@redhat.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Link: https://lore.kernel.org/r/20220108150948.3988790-1-trix@redhat.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/i3c/master/dw-i3c-master.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
    index 03a368da51b95..51a8608203de7 100644
    --- a/drivers/i3c/master/dw-i3c-master.c
    +++ b/drivers/i3c/master/dw-i3c-master.c
    @@ -793,6 +793,10 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m)
    return -ENOMEM;

    pos = dw_i3c_master_get_free_pos(master);
    + if (pos < 0) {
    + dw_i3c_master_free_xfer(xfer);
    + return pos;
    + }
    cmd = &xfer->cmds[0];
    cmd->cmd_hi = 0x1;
    cmd->cmd_lo = COMMAND_PORT_DEV_COUNT(master->maxdevs - pos) |
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:14    [W:4.023 / U:1.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site