lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0764/1039] MIPS: OCTEON: add put_device() after of_find_device_by_node()
    Date
    From: Ye Guojin <ye.guojin@zte.com.cn>

    [ Upstream commit 858779df1c0787d3fec827fb705708df9ebdb15b ]

    This was found by coccicheck:
    ./arch/mips/cavium-octeon/octeon-platform.c, 332, 1-7, ERROR missing
    put_device; call of_find_device_by_node on line 324, but without a
    corresponding object release within this function.
    ./arch/mips/cavium-octeon/octeon-platform.c, 395, 1-7, ERROR missing
    put_device; call of_find_device_by_node on line 387, but without a
    corresponding object release within this function.
    ./arch/mips/cavium-octeon/octeon-usb.c, 512, 3-9, ERROR missing
    put_device; call of_find_device_by_node on line 515, but without a
    corresponding object release within this function.
    ./arch/mips/cavium-octeon/octeon-usb.c, 543, 1-7, ERROR missing
    put_device; call of_find_device_by_node on line 515, but without a
    corresponding object release within this function.

    Reported-by: Zeal Robot <zealci@zte.com.cn>
    Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/cavium-octeon/octeon-platform.c | 2 ++
    arch/mips/cavium-octeon/octeon-usb.c | 1 +
    2 files changed, 3 insertions(+)

    diff --git a/arch/mips/cavium-octeon/octeon-platform.c b/arch/mips/cavium-octeon/octeon-platform.c
    index d56e9b9d2e434..a994022e32c9f 100644
    --- a/arch/mips/cavium-octeon/octeon-platform.c
    +++ b/arch/mips/cavium-octeon/octeon-platform.c
    @@ -328,6 +328,7 @@ static int __init octeon_ehci_device_init(void)

    pd->dev.platform_data = &octeon_ehci_pdata;
    octeon_ehci_hw_start(&pd->dev);
    + put_device(&pd->dev);

    return ret;
    }
    @@ -391,6 +392,7 @@ static int __init octeon_ohci_device_init(void)

    pd->dev.platform_data = &octeon_ohci_pdata;
    octeon_ohci_hw_start(&pd->dev);
    + put_device(&pd->dev);

    return ret;
    }
    diff --git a/arch/mips/cavium-octeon/octeon-usb.c b/arch/mips/cavium-octeon/octeon-usb.c
    index 6e4d3619137af..4df919d26b082 100644
    --- a/arch/mips/cavium-octeon/octeon-usb.c
    +++ b/arch/mips/cavium-octeon/octeon-usb.c
    @@ -537,6 +537,7 @@ static int __init dwc3_octeon_device_init(void)
    devm_iounmap(&pdev->dev, base);
    devm_release_mem_region(&pdev->dev, res->start,
    resource_size(res));
    + put_device(&pdev->dev);
    }
    } while (node != NULL);

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:14    [W:2.417 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site