lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0832/1039] mm/page_isolation: unset migratetype directly for non Buddy page
    Date
    From: Chen Wandun <chenwandun@huawei.com>

    [ Upstream commit 721fb891ad0b3956d5c168b2931e3e5e4fb7ca40 ]

    In unset_migratetype_isolate(), we can bypass the call to
    move_freepages_block() for non-buddy pages.

    It will save a few cpu cycles for some situations such as cma and
    hugetlb when allocating continue pages, in these situation function
    alloc_contig_pages will be called.

    alloc_contig_pages
    __alloc_contig_migrate_range
    isolate_freepages_range ==> pages has been remove from buddy
    undo_isolate_page_range
    unset_migratetype_isolate ==> can directly set migratetype

    [osalvador@suse.de: changelog tweak]

    Link: https://lkml.kernel.org/r/20211229033649.2760586-1-chenwandun@huawei.com
    Fixes: 3c605096d315 ("mm/page_alloc: restrict max order of merging on isolated pageblock")
    Signed-off-by: Chen Wandun <chenwandun@huawei.com>
    Reviewed-by: Oscar Salvador <osalvador@suse.de>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Cc: Wang Kefeng <wangkefeng.wang@huawei.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    mm/page_isolation.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/mm/page_isolation.c b/mm/page_isolation.c
    index f67c4c70f17f6..6a0ddda6b3c53 100644
    --- a/mm/page_isolation.c
    +++ b/mm/page_isolation.c
    @@ -115,7 +115,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
    * onlining - just onlined memory won't immediately be considered for
    * allocation.
    */
    - if (!isolated_page) {
    + if (!isolated_page && PageBuddy(page)) {
    nr_pages = move_freepages_block(zone, page, migratetype, NULL);
    __mod_zone_freepage_state(zone, nr_pages, migratetype);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:14    [W:2.966 / U:1.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site