lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0350/1039] software node: fix wrong node passed to find nargs_prop
    Date
    From: Clément Léger <clement.leger@bootlin.com>

    [ Upstream commit c5fc5ba8b6b7bebc05e45036a33405b4c5036c2f ]

    nargs_prop refers to a property located in the reference that is found
    within the nargs property. Use the correct reference node in call to
    property_entry_read_int_array() to retrieve the correct nargs value.

    Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
    Signed-off-by: Clément Léger <clement.leger@bootlin.com>
    Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Reviewed-by: Daniel Scally <djrscally@gmail.com>
    Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/base/swnode.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
    index 4debcea4fb12d..0a482212c7e8e 100644
    --- a/drivers/base/swnode.c
    +++ b/drivers/base/swnode.c
    @@ -529,7 +529,7 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,
    return -ENOENT;

    if (nargs_prop) {
    - error = property_entry_read_int_array(swnode->node->properties,
    + error = property_entry_read_int_array(ref->node->properties,
    nargs_prop, sizeof(u32),
    &nargs_prop_val, 1);
    if (error)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-09-17 16:13    [W:2.753 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site