Messages in this thread | | | From | Alex Deucher <> | Date | Mon, 24 Jan 2022 17:08:28 -0500 | Subject | Re: [PATCH v2] drm/amd/pm: return -ENOTSUPP if there is no get_dpm_ultimate_freq function |
| |
Applied. Thanks!
Alex
On Mon, Jan 24, 2022 at 3:18 PM <trix@redhat.com> wrote: > > From: Tom Rix <trix@redhat.com> > > clang static analysis reports this represenative problem > amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value > return clk_freq * 100; > ~~~~~~~~ ^ > > If there is no get_dpm_ultimate_freq function, > smu_get_dpm_freq_range returns success without setting the > output min,max parameters. So return an -ENOTSUPP error. > > Fixes: e5ef784b1e17 ("drm/amd/powerplay: revise calling chain on retrieving frequency range") > Signed-off-by: Tom Rix <trix@redhat.com> > --- > v2: return error instead of initializing min/max > > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > index 5ace30434e603..264eb09ccfd51 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > @@ -116,7 +116,7 @@ int smu_get_dpm_freq_range(struct smu_context *smu, > uint32_t *min, > uint32_t *max) > { > - int ret = 0; > + int ret = -ENOTSUPP; > > if (!min && !max) > return -EINVAL; > -- > 2.26.3 >
| |