Messages in this thread | | | Subject | Re: [PATCH 5/7] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain | From | Lu Baolu <> | Date | Tue, 25 Jan 2022 10:59:34 +0800 |
| |
On 1/24/22 5:29 PM, Christoph Hellwig wrote: > On Mon, Jan 24, 2022 at 03:11:00PM +0800, Lu Baolu wrote: >> The supported page sizes of an iommu_domain are saved in the pgsize_bitmap >> field. Retrieve the value from the right place. >> >> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> >> Reviewed-by: Robin Murphy <robin.murphy@arm.com> >> Link: https://lore.kernel.org/r/20211218074546.1772553-1-baolu.lu@linux.intel.com > > Looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Wouldn't it mke sense to remove the pgsize_bitmap in struct iommu_ops > and initialize the domain field in the domain_alloc methods? Or am I > missing something? >
It looks reasonable to me. The pgsize_bitmap is an attribute of a domain that provides the map/unmap interfaces. It could be moved out of the iommu_ops structure.
Best regards, baolu
| |