lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0782/1039] PCI: mediatek-gen3: Disable DVFSRC voltage request
    Date
    From: Jianjun Wang <jianjun.wang@mediatek.com>

    [ Upstream commit ab344fd43f2958726d17d651c0cb692c67dca382 ]

    When the DVFSRC (dynamic voltage and frequency scaling resource collector)
    feature is not implemented, the PCIe hardware will assert a voltage request
    signal when exit from the L1 PM Substates to request a specific Vcore
    voltage, but cannot receive the voltage ready signal, which will cause
    the link to fail to exit the L1 PM Substates.

    Disable DVFSRC voltage request by default, we need to find a common way to
    enable it in the future.

    Link: https://lore.kernel.org/r/20211015063602.29058-1-jianjun.wang@mediatek.com
    Fixes: d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")
    Tested-by: Qizhong Cheng <qizhong.cheng@mediatek.com>
    Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
    Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c
    index 17c59b0d6978b..21207df680ccf 100644
    --- a/drivers/pci/controller/pcie-mediatek-gen3.c
    +++ b/drivers/pci/controller/pcie-mediatek-gen3.c
    @@ -79,6 +79,9 @@
    #define PCIE_ICMD_PM_REG 0x198
    #define PCIE_TURN_OFF_LINK BIT(4)

    +#define PCIE_MISC_CTRL_REG 0x348
    +#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1)
    +
    #define PCIE_TRANS_TABLE_BASE_REG 0x800
    #define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4
    #define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8
    @@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct mtk_pcie_port *port)
    val &= ~PCIE_INTX_ENABLE;
    writel_relaxed(val, port->base + PCIE_INT_ENABLE_REG);

    + /* Disable DVFSRC voltage request */
    + val = readl_relaxed(port->base + PCIE_MISC_CTRL_REG);
    + val |= PCIE_DISABLE_DVFSRC_VLT_REQ;
    + writel_relaxed(val, port->base + PCIE_MISC_CTRL_REG);
    +
    /* Assert all reset signals */
    val = readl_relaxed(port->base + PCIE_RST_CTRL_REG);
    val |= PCIE_MAC_RSTB | PCIE_PHY_RSTB | PCIE_BRG_RSTB | PCIE_PE_RSTB;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 04:09    [W:4.507 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site