lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0922/1039] scsi: ufs: ufs-mediatek: Fix error checking in ufs_mtk_init_va09_pwr_ctrl()
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit 3ba880a12df5aa4488c18281701b5b1bc3d4531a upstream.

    The function regulator_get() returns an error pointer. Use IS_ERR() to
    validate the return value.

    Link: https://lore.kernel.org/r/20211222070930.9449-1-linmq006@gmail.com
    Fixes: cf137b3ea49a ("scsi: ufs-mediatek: Support VA09 regulator operations")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/ufs/ufs-mediatek.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/ufs/ufs-mediatek.c
    +++ b/drivers/scsi/ufs/ufs-mediatek.c
    @@ -557,7 +557,7 @@ static void ufs_mtk_init_va09_pwr_ctrl(s
    struct ufs_mtk_host *host = ufshcd_get_variant(hba);

    host->reg_va09 = regulator_get(hba->dev, "va09");
    - if (!host->reg_va09)
    + if (IS_ERR(host->reg_va09))
    dev_info(hba->dev, "failed to get va09");
    else
    host->caps |= UFS_MTK_CAP_VA09_PWR_CTRL;

    \
     
     \ /
      Last update: 2022-01-25 04:09    [W:3.067 / U:1.804 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site