lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0964/1039] gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit 0b39536cc699db6850c426db7f9cb45923de40c5 upstream.

    platform_get_irq() returns negative error number instead 0 on failure.
    And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
    return irq;

    Fix the check of return value to catch errors correctly.

    Fixes: 76c47d1449fc ("gpio: mpc8xxx: Add ACPI support")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpio/gpio-mpc8xxx.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/gpio/gpio-mpc8xxx.c
    +++ b/drivers/gpio/gpio-mpc8xxx.c
    @@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform
    }

    mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
    - if (!mpc8xxx_gc->irqn)
    - return 0;
    + if (mpc8xxx_gc->irqn < 0)
    + return mpc8xxx_gc->irqn;

    mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
    MPC8XXX_GPIO_PINS,

    \
     
     \ /
      Last update: 2022-01-25 03:56    [W:5.406 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site