lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 1002/1039] perf metricgroup: Fix use after free in metric__new()
    Date
    From: José Expósito <jose.exposito89@gmail.com>

    commit e000ea0beffb5497425054b151369fe37a792ece upstream.

    We shouldn't free() something that will be used in the next line, fix
    it.

    Fixes: b85a4d61d3022608 ("perf metric: Allow modifiers on metrics")
    Addresses-Coverity-ID: 1494000
    Signed-off-by: José Expósito <jose.exposito89@gmail.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Ian Rogers <irogers@google.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: John Garry <john.garry@huawei.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20211208171113.22089-1-jose.exposito89@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    tools/perf/util/metricgroup.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/tools/perf/util/metricgroup.c
    +++ b/tools/perf/util/metricgroup.c
    @@ -209,8 +209,8 @@ static struct metric *metric__new(const
    m->metric_name = pe->metric_name;
    m->modifier = modifier ? strdup(modifier) : NULL;
    if (modifier && !m->modifier) {
    - free(m);
    expr__ctx_free(m->pctx);
    + free(m);
    return NULL;
    }
    m->metric_expr = pe->metric_expr;

    \
     
     \ /
      Last update: 2022-01-25 03:56    [W:2.406 / U:0.652 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site