Messages in this thread | | | Date | Mon, 24 Jan 2022 14:45:04 -0600 | From | "Gustavo A. R. Silva" <> | Subject | Re: [PATCH] Revert "Makefile: Do not quote value for CONFIG_CC_IMPLICIT_FALLTHROUGH" |
| |
On Mon, Jan 24, 2022 at 11:55:43AM -0800, Nick Desaulniers wrote: > + Salvatore, Kees, Gustavo, Nathan > > On Wed, Jan 19, 2022 at 9:31 PM Masahiro Yamada <masahiroy@kernel.org> wrote: > > > > This reverts commit cd8c917a56f20f48748dd43d9ae3caff51d5b987. > > > > Commit 129ab0d2d9f3 ("kbuild: do not quote string values in > > include/config/auto.conf") provided the final solution. > > > > Now reverting the temporary workaround. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Great!
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks -- Gustavo
> > > --- > > > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index 3f07f0f04475..c94559a97dca 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -778,7 +778,7 @@ stackp-flags-$(CONFIG_STACKPROTECTOR_STRONG) := -fstack-protector-strong > > KBUILD_CFLAGS += $(stackp-flags-y) > > > > KBUILD_CFLAGS-$(CONFIG_WERROR) += -Werror > > -KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH:"%"=%) > > +KBUILD_CFLAGS += $(KBUILD_CFLAGS-y) $(CONFIG_CC_IMPLICIT_FALLTHROUGH) > > > > ifdef CONFIG_CC_IS_CLANG > > KBUILD_CPPFLAGS += -Qunused-arguments > > -- > > 2.32.0 > > > > > -- > Thanks, > ~Nick Desaulniers
| |