lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0442/1039] amt: fix wrong return type of amt_send_membership_update()
    Date
    From: Taehee Yoo <ap420073@gmail.com>

    [ Upstream commit dd3ca4c5184ea98e40acb8eb293d85b88ea04ee2 ]

    amt_send_membership_update() would return -1 but it's return type is bool.
    So, it should be used TRUE instead of -1.

    Fixes: cbc21dc1cfe9 ("amt: add data plane of amt interface")
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Taehee Yoo <ap420073@gmail.com>
    Link: https://lore.kernel.org/r/20220109163702.6331-1-ap420073@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/amt.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/amt.c b/drivers/net/amt.c
    index b732ee9a50ef9..d3a9dda6c7286 100644
    --- a/drivers/net/amt.c
    +++ b/drivers/net/amt.c
    @@ -1106,7 +1106,7 @@ static bool amt_send_membership_query(struct amt_dev *amt,
    rt = ip_route_output_key(amt->net, &fl4);
    if (IS_ERR(rt)) {
    netdev_dbg(amt->dev, "no route to %pI4\n", &tunnel->ip4);
    - return -1;
    + return true;
    }

    amtmq = skb_push(skb, sizeof(*amtmq));
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 01:14    [W:3.777 / U:0.760 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site