lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0283/1039] ARM: dts: gemini: NAS4220-B: fis-index-block with 128 KiB sectors
    Date
    From: Christian Lamparter <chunkeey@gmail.com>

    [ Upstream commit 4754eab7e5a78bdefe7a960c5c260c95ebbb5fa6 ]

    Steven Maddox reported in the OpenWrt bugzilla, that his
    RaidSonic IB-NAS4220-B was no longer booting with the new
    OpenWrt 21.02 (uses linux 5.10's device-tree). However, it was
    working with the previous OpenWrt 19.07 series (uses 4.14).

    |[ 5.548038] No RedBoot partition table detected in 30000000.flash
    |[ 5.618553] Searching for RedBoot partition table in 30000000.flash at offset 0x0
    |[ 5.739093] No RedBoot partition table detected in 30000000.flash
    |...
    |[ 7.039504] Waiting for root device /dev/mtdblock3...

    The provided bootlog shows that the RedBoot partition parser was
    looking for the partition table "at offset 0x0". Which is strange
    since the comment in the device-tree says it should be at 0xfe0000.

    Further digging on the internet led to a review site that took
    some useful PCB pictures of their review unit back in February 2009.
    Their picture shows a Spansion S29GL128N11TFI01 flash chip.

    >From Spansion's Datasheet:
    "S29GL128N: One hundred twenty-eight 64 Kword (128 Kbyte) sectors"
    Steven also provided a "cat /sys/class/mtd/mtd0/erasesize" from his
    unit: "131072".

    With the 128 KiB Sector/Erasesize in mind. This patch changes the
    fis-index-block property to (0xfe0000 / 0x20000) = 0x7f.

    Fixes: b5a923f8c739 ("ARM: dts: gemini: Switch to redboot partition parsing")
    Reported-by: Steven Maddox <s.maddox@lantizia.me.uk>
    Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Tested-by: Steven Maddox <s.maddox@lantizia.me.uk>
    Link: https://lore.kernel.org/r/20211206004334.4169408-1-linus.walleij@linaro.org'
    Bugzilla: https://bugs.openwrt.org/index.php?do=details&task_id=4137
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/arm/boot/dts/gemini-nas4220b.dts | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/arm/boot/dts/gemini-nas4220b.dts b/arch/arm/boot/dts/gemini-nas4220b.dts
    index 13112a8a5dd88..6544c730340fa 100644
    --- a/arch/arm/boot/dts/gemini-nas4220b.dts
    +++ b/arch/arm/boot/dts/gemini-nas4220b.dts
    @@ -84,7 +84,7 @@
    partitions {
    compatible = "redboot-fis";
    /* Eraseblock at 0xfe0000 */
    - fis-index-block = <0x1fc>;
    + fis-index-block = <0x7f>;
    };
    };

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 01:14    [W:2.145 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site