lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0551/1039] selftests/bpf: Destroy XDP link correctly
    Date
    From: Andrii Nakryiko <andrii@kernel.org>

    [ Upstream commit f91231eeeed752119f49eb6620cae44ec745a007 ]

    bpf_link__detach() was confused with bpf_link__destroy() and leaves
    leaked FD in the process. Fix the problem.

    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Reviewed-by: Hengqi Chen <hengqi.chen@gmail.com>
    Link: https://lore.kernel.org/bpf/20211107165521.9240-9-andrii@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c b/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c
    index 7589c03fd26be..eb2feaac81fe2 100644
    --- a/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c
    +++ b/tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c
    @@ -204,8 +204,8 @@ static int pass_ack(struct migrate_reuseport_test_case *test_case)
    {
    int err;

    - err = bpf_link__detach(test_case->link);
    - if (!ASSERT_OK(err, "bpf_link__detach"))
    + err = bpf_link__destroy(test_case->link);
    + if (!ASSERT_OK(err, "bpf_link__destroy"))
    return -1;

    test_case->link = NULL;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 01:11    [W:4.017 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site