lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0129/1039] media: atomisp: fix uninitialized bug in gmin_get_pmic_id_and_addr()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit cb4d67a998e97365afdf34965b069601da1dae60 ]

    The "power" pointer is not initialized on the else path and that would
    lead to an Oops.

    Link: https://lore.kernel.org/linux-media/20211012082150.GA31086@kili
    Fixes: c30f4cb2d4c7 ("media: atomisp: Refactor PMIC detection to a separate function")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
    index d8c9e31314b2e..62dc06e224765 100644
    --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
    +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
    @@ -481,7 +481,7 @@ fail:

    static u8 gmin_get_pmic_id_and_addr(struct device *dev)
    {
    - struct i2c_client *power;
    + struct i2c_client *power = NULL;
    static u8 pmic_i2c_addr;

    if (pmic_id)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 01:11    [W:2.859 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site