lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0150/1039] mctp/test: Update refcount checking in route fragment tests
    Date
    From: Jeremy Kerr <jk@codeconstruct.com.au>

    [ Upstream commit f6ef47e5bdc6f652176e433b02317fc83049f8d7 ]

    In 99ce45d5e, we moved a route refcount decrement from
    mctp_do_fragment_route into the caller. This invalidates the assumption
    that the route test makes about refcount behaviour, so the route tests
    fail.

    This change fixes the test case to suit the new refcount behaviour.

    Fixes: 99ce45d5e7db ("mctp: Implement extended addressing")
    Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/mctp/test/route-test.c | 5 -----
    1 file changed, 5 deletions(-)

    diff --git a/net/mctp/test/route-test.c b/net/mctp/test/route-test.c
    index 36fac3daf86a4..86ad15abf8978 100644
    --- a/net/mctp/test/route-test.c
    +++ b/net/mctp/test/route-test.c
    @@ -150,11 +150,6 @@ static void mctp_test_fragment(struct kunit *test)
    rt = mctp_test_create_route(&init_net, NULL, 10, mtu);
    KUNIT_ASSERT_TRUE(test, rt);

    - /* The refcount would usually be incremented as part of a route lookup,
    - * but we're setting the route directly here.
    - */
    - refcount_inc(&rt->rt.refs);
    -
    rc = mctp_do_fragment_route(&rt->rt, skb, mtu, MCTP_TAG_OWNER);
    KUNIT_EXPECT_FALSE(test, rc);

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 01:11    [W:4.024 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site