lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0630/1039] rtw89: dont kick off TX DMA if failed to write skb
    Date
    From: Ping-Ke Shih <pkshih@realtek.com>

    [ Upstream commit a58fdb7c843a37d6598204c6513961feefdadc6a ]

    This is found by Smatch static checker warning:
    drivers/net/wireless/realtek/rtw89/mac80211.c:31 rtw89_ops_tx()
    error: uninitialized symbol 'qsel'.

    The warning is because 'qsel' isn't filled by rtw89_core_tx_write() due to
    failed to write. The way to fix it is to avoid kicking off TX DMA, so add
    'return' to the failure case.

    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
    Signed-off-by: Kalle Valo <kvalo@kernel.org>
    Link: https://lore.kernel.org/r/20211201093816.13806-1-pkshih@realtek.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/realtek/rtw89/mac80211.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wireless/realtek/rtw89/mac80211.c b/drivers/net/wireless/realtek/rtw89/mac80211.c
    index 16dc6fb7dbb0b..e9d61e55e2d92 100644
    --- a/drivers/net/wireless/realtek/rtw89/mac80211.c
    +++ b/drivers/net/wireless/realtek/rtw89/mac80211.c
    @@ -27,6 +27,7 @@ static void rtw89_ops_tx(struct ieee80211_hw *hw,
    if (ret) {
    rtw89_err(rtwdev, "failed to transmit skb: %d\n", ret);
    ieee80211_free_txskb(hw, skb);
    + return;
    }
    rtw89_core_tx_kick_off(rtwdev, qsel);
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 01:11    [W:3.511 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site