lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0534/1039] mailbox: imx: Fix an IS_ERR() vs NULL bug
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 05d06f37196b2e3abeff2b98b785c8803865e646 ]

    The devm_kzalloc() function does not return error pointers, it returns
    NULL on failure.

    Fixes: 97961f78e8bc ("mailbox: imx: support i.MX8ULP S4 MU")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Peng Fan <peng.fan@nxp.com>
    Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mailbox/imx-mailbox.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c
    index ffe36a6bef9e0..544de2db64531 100644
    --- a/drivers/mailbox/imx-mailbox.c
    +++ b/drivers/mailbox/imx-mailbox.c
    @@ -563,8 +563,8 @@ static int imx_mu_probe(struct platform_device *pdev)
    size = sizeof(struct imx_sc_rpc_msg_max);

    priv->msg = devm_kzalloc(dev, size, GFP_KERNEL);
    - if (IS_ERR(priv->msg))
    - return PTR_ERR(priv->msg);
    + if (!priv->msg)
    + return -ENOMEM;

    priv->clk = devm_clk_get(dev, NULL);
    if (IS_ERR(priv->clk)) {
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 01:11    [W:3.006 / U:0.464 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site