lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 686/846] remoteproc: imx_rproc: Fix a resource leak in the remove function
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit 4da96175014be67c846fd274eace08066e525d75 upstream.

    'priv->workqueue' is destroyed in the error handling path of the probe but
    not in the remove function.

    Add the missing call to release some resources.

    Cc: stable <stable@vger.kernel.org>
    Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Peng Fan <peng.fan@nxp.com>
    Tested-by: Peng Fan <peng.fan@nxp.com>
    Link: https://lore.kernel.org/r/d28ca94a4031bd7297d47c2164e18885a5a6ec19.1634366546.git.christophe.jaillet@wanadoo.fr
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/remoteproc/imx_rproc.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/remoteproc/imx_rproc.c
    +++ b/drivers/remoteproc/imx_rproc.c
    @@ -830,6 +830,7 @@ static int imx_rproc_remove(struct platf
    clk_disable_unprepare(priv->clk);
    rproc_del(rproc);
    imx_rproc_free_mbox(rproc);
    + destroy_workqueue(priv->workqueue);
    rproc_free(rproc);

    return 0;

    \
     
     \ /
      Last update: 2022-01-25 00:48    [W:2.140 / U:1.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site