lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 623/846] powerpc/6xx: add missing of_node_put
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    [ Upstream commit f6e82647ff71d427d4148964b71f239fba9d7937 ]

    for_each_compatible_node performs an of_node_get on each iteration, so
    a break out of the loop requires an of_node_put.

    A simplified version of the semantic patch that fixes this problem is as
    follows (http://coccinelle.lip6.fr):

    // <smpl>
    @@
    expression e;
    local idexpression n;
    @@

    @@
    local idexpression n;
    expression e;
    @@

    for_each_compatible_node(n,...) {
    ...
    (
    of_node_put(n);
    |
    e = n
    |
    + of_node_put(n);
    ? break;
    )
    ...
    }
    ... when != n
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/1448051604-25256-2-git-send-email-Julia.Lawall@lip6.fr
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/embedded6xx/hlwd-pic.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
    index 15396333a90bd..a4b020e4b6af0 100644
    --- a/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
    +++ b/arch/powerpc/platforms/embedded6xx/hlwd-pic.c
    @@ -214,6 +214,7 @@ void hlwd_pic_probe(void)
    irq_set_chained_handler(cascade_virq,
    hlwd_pic_irq_cascade);
    hlwd_irq_host = host;
    + of_node_put(np);
    break;
    }
    }
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 00:40    [W:3.885 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site