Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit | Date | Mon, 24 Jan 2022 21:36:00 +0100 |
| |
On Mon, Jan 24 2022 at 21:21, Thomas Gleixner wrote: > > Hrm. This is odd. > >> +/* Associate a PASID with an mm_struct: */ >> +static inline void mm_pasid_get(struct mm_struct *mm, u32 pasid) >> +{ >> + mm->pasid = pasid; >> +} > > This does not get anything. It sets the allocated PASID in the mm. The > refcount on the PASID was already taken by the allocation. So this > should be mm_pasid_set() or mm_pasid_install(), right?
And as a result of all this ioasid_get() is now left without users...
Thanks,
tglx
| |