lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0918/1039] net: usb: Correct reset handling of smsc95xx
    Date
    From: Markus Reichl <m.reichl@fivetechno.de>

    commit 0bf3885324a8599e3af4c7379b8d4f621c9bbffa upstream.

    On boards with LAN9514 and no preconfigured MAC address we don't get an
    ip address from DHCP after commit a049a30fc27c ("net: usb: Correct PHY handling
    of smsc95xx") anymore. Adding an explicit reset before starting the phy
    fixes the issue.

    [1]
    https://lore.kernel.org/netdev/199eebbd6b97f52b9119c9fa4fd8504f8a34de18.camel@collabora.com/

    From: Gabriel Hojda <ghojda@yo2urs.ro>
    Fixes: a049a30fc27c ("net: usb: Correct PHY handling of smsc95xx")
    Signed-off-by: Gabriel Hojda <ghojda@yo2urs.ro>
    Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
    Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/usb/smsc95xx.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/net/usb/smsc95xx.c
    +++ b/drivers/net/usb/smsc95xx.c
    @@ -1962,7 +1962,8 @@ static const struct driver_info smsc95xx
    .bind = smsc95xx_bind,
    .unbind = smsc95xx_unbind,
    .link_reset = smsc95xx_link_reset,
    - .reset = smsc95xx_start_phy,
    + .reset = smsc95xx_reset,
    + .check_connect = smsc95xx_start_phy,
    .stop = smsc95xx_stop,
    .rx_fixup = smsc95xx_rx_fixup,
    .tx_fixup = smsc95xx_tx_fixup,

    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:6.576 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site