lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0868/1039] drm/amdgpu: Fix rejecting Tahiti GPUs
    Date
    From: Lukas Fink <lukas.fink1@gmail.com>

    commit 3993a799fc971bc9b918bd969aa55864447b5dde upstream.

    eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added
    generic bindings to amdgpu so that that it binds to all display class devices
    with VID 0x1002 and then rejects those in amdgpu_pci_probe.

    Unfortunately it reuses a driver_data value of 0 to detect those new bindings,
    which is already used to denote CHIP_TAHITI ASICs.

    The driver_data value given to those new bindings was changed in
    dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default")
    to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe
    was forgotten to be changed. Therefore, it still rejects Tahiti GPUs.

    Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860
    Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device")

    Cc: stable@vger.kernel.org
    Signed-off-by: Lukas Fink <lukas.fink1@gmail.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
    @@ -1928,7 +1928,7 @@ static int amdgpu_pci_probe(struct pci_d
    return -ENODEV;
    }

    - if (flags == 0) {
    + if (flags == CHIP_IP_DISCOVERY) {
    DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n");
    return -ENODEV;
    }

    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:4.048 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site