lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0898/1039] ext4: destroy ext4_fc_dentry_cachep kmemcache on module removal
    Date
    From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

    commit ab047d516dea72f011c15c04a929851e4d053109 upstream.

    The kmemcache for ext4_fc_dentry_cachep remains registered after module
    removal.

    Destroy ext4_fc_dentry_cachep kmemcache on module removal.

    Fixes: aa75f4d3daaeb ("ext4: main fast-commit commit path")
    Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    Reviewed-by: Lukas Czerner <lczerner@redhat.com>
    Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
    Link: https://lore.kernel.org/r/20211110134640.lyku5vklvdndw6uk@linutronix.de
    Link: https://lore.kernel.org/r/YbiK3JetFFl08bd7@linutronix.de
    Link: https://lore.kernel.org/r/20211223164436.2628390-1-bigeasy@linutronix.de
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ext4/ext4.h | 1 +
    fs/ext4/fast_commit.c | 5 +++++
    fs/ext4/super.c | 2 ++
    3 files changed, 8 insertions(+)

    --- a/fs/ext4/ext4.h
    +++ b/fs/ext4/ext4.h
    @@ -2935,6 +2935,7 @@ bool ext4_fc_replay_check_excluded(struc
    void ext4_fc_replay_cleanup(struct super_block *sb);
    int ext4_fc_commit(journal_t *journal, tid_t commit_tid);
    int __init ext4_fc_init_dentry_cache(void);
    +void ext4_fc_destroy_dentry_cache(void);

    /* mballoc.c */
    extern const struct seq_operations ext4_mb_seq_groups_ops;
    --- a/fs/ext4/fast_commit.c
    +++ b/fs/ext4/fast_commit.c
    @@ -2195,3 +2195,8 @@ int __init ext4_fc_init_dentry_cache(voi

    return 0;
    }
    +
    +void ext4_fc_destroy_dentry_cache(void)
    +{
    + kmem_cache_destroy(ext4_fc_dentry_cachep);
    +}
    --- a/fs/ext4/super.c
    +++ b/fs/ext4/super.c
    @@ -6662,6 +6662,7 @@ static int __init ext4_init_fs(void)
    out:
    unregister_as_ext2();
    unregister_as_ext3();
    + ext4_fc_destroy_dentry_cache();
    out05:
    destroy_inodecache();
    out1:
    @@ -6688,6 +6689,7 @@ static void __exit ext4_exit_fs(void)
    unregister_as_ext2();
    unregister_as_ext3();
    unregister_filesystem(&ext4_fs_type);
    + ext4_fc_destroy_dentry_cache();
    destroy_inodecache();
    ext4_exit_mballoc();
    ext4_exit_sysfs();

    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:2.191 / U:0.908 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site