lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 559/563] lib82596: Fix IRQ check in sni_82596_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit 99218cbf81bf21355a3de61cd46a706d36e900e6 upstream.

    platform_get_irq() returns negative error number instead 0 on failure.
    And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
    return irq;

    Fix the check of return value to catch errors correctly.

    Fixes: 115978859272 ("i825xx: Move the Intel 82586/82593/82596 based drivers")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/i825xx/sni_82596.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/net/ethernet/i825xx/sni_82596.c
    +++ b/drivers/net/ethernet/i825xx/sni_82596.c
    @@ -117,9 +117,10 @@ static int sni_82596_probe(struct platfo
    netdevice->dev_addr[5] = readb(eth_addr + 0x06);
    iounmap(eth_addr);

    - if (!netdevice->irq) {
    + if (netdevice->irq < 0) {
    printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n",
    __FILE__, netdevice->base_addr);
    + retval = netdevice->irq;
    goto probe_failed;
    }


    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:4.136 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site