lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 343/846] net/mlx5: Fix access to sf_dev_table on allocation failure
    Date
    From: Shay Drory <shayd@nvidia.com>

    [ Upstream commit a1c7c49c2091926962f8c1c866d386febffec5d8 ]

    Even when SF devices are supported, the SF device table allocation
    can still fail.
    In such case mlx5_sf_dev_supported still reports true, but SF device
    table is invalid. This can result in NULL table access.

    Hence, fix it by adding NULL table check.

    Fixes: 1958fc2f0712 ("net/mlx5: SF, Add auxiliary device driver")
    Signed-off-by: Shay Drory <shayd@nvidia.com>
    Reviewed-by: Parav Pandit <parav@nvidia.com>
    Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c
    index 871c2fbe18d39..64bbc18332d56 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c
    @@ -28,10 +28,7 @@ bool mlx5_sf_dev_allocated(const struct mlx5_core_dev *dev)
    {
    struct mlx5_sf_dev_table *table = dev->priv.sf_dev_table;

    - if (!mlx5_sf_dev_supported(dev))
    - return false;
    -
    - return !xa_empty(&table->devices);
    + return table && !xa_empty(&table->devices);
    }

    static ssize_t sfnum_show(struct device *dev, struct device_attribute *attr, char *buf)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:4.396 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site