lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 1006/1039] devlink: Remove misleading internal_flags from health reporter dump
    Date
    From: Leon Romanovsky <leonro@nvidia.com>

    commit e9538f8270db24d272659e15841854c7ea11119e upstream.

    DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET command doesn't have .doit callback
    and has no use in internal_flags at all. Remove this misleading assignment.

    Fixes: e44ef4e4516c ("devlink: Hang reporter's dump method on a dumpit cb")
    Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/core/devlink.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/net/core/devlink.c
    +++ b/net/core/devlink.c
    @@ -8840,8 +8840,6 @@ static const struct genl_small_ops devli
    GENL_DONT_VALIDATE_DUMP_STRICT,
    .dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit,
    .flags = GENL_ADMIN_PERM,
    - .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT |
    - DEVLINK_NL_FLAG_NO_LOCK,
    },
    {
    .cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR,

    \
     
     \ /
      Last update: 2022-01-25 00:11    [W:2.277 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site