lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0965/1039] gpio: idt3243x: Fix IRQ check in idt_gpio_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit 30fee1d7462a446ade399c0819717a830cbdca69 upstream.

    platform_get_irq() returns negative error number instead 0 on failure.
    And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
    return irq;

    Fix the check of return value to catch errors correctly.

    Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpio/gpio-idt3243x.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/gpio/gpio-idt3243x.c
    +++ b/drivers/gpio/gpio-idt3243x.c
    @@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platfor
    return PTR_ERR(ctrl->pic);

    parent_irq = platform_get_irq(pdev, 0);
    - if (!parent_irq)
    - return -EINVAL;
    + if (parent_irq < 0)
    + return parent_irq;

    girq = &ctrl->gc.irq;
    girq->chip = &idt_gpio_irqchip;

    \
     
     \ /
      Last update: 2022-01-25 00:10    [W:4.029 / U:0.208 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site