lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0735/1039] powerpc/powernv: add missing of_node_put
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    [ Upstream commit 7d405a939ca960162eb30c1475759cb2fdf38f8c ]

    for_each_compatible_node performs an of_node_get on each iteration, so
    a break out of the loop requires an of_node_put.

    A simplified version of the semantic patch that fixes this problem is as
    follows (http://coccinelle.lip6.fr):

    // <smpl>
    @@
    local idexpression n;
    expression e;
    @@

    for_each_compatible_node(n,...) {
    ...
    (
    of_node_put(n);
    |
    e = n
    |
    + of_node_put(n);
    ? break;
    )
    ...
    }
    ... when != n
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/1448051604-25256-4-git-send-email-Julia.Lawall@lip6.fr
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/powerpc/platforms/powernv/opal-lpc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/powerpc/platforms/powernv/opal-lpc.c b/arch/powerpc/platforms/powernv/opal-lpc.c
    index 1e5d51db40f84..5390c888db162 100644
    --- a/arch/powerpc/platforms/powernv/opal-lpc.c
    +++ b/arch/powerpc/platforms/powernv/opal-lpc.c
    @@ -396,6 +396,7 @@ void __init opal_lpc_init(void)
    if (!of_get_property(np, "primary", NULL))
    continue;
    opal_lpc_chip_id = of_get_ibm_chip_id(np);
    + of_node_put(np);
    break;
    }
    if (opal_lpc_chip_id < 0)
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:40    [W:3.653 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site