lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 034/846] ksmbd: uninitialized variable in create_socket()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit b207602fb04537cb21ac38fabd7577eca2fa05ae upstream.

    The "ksmbd_socket" variable is not initialized on this error path.

    Cc: stable@vger.kernel.org
    Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Namjae Jeon <linkinjeon@kernel.org>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/ksmbd/transport_tcp.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/fs/ksmbd/transport_tcp.c
    +++ b/fs/ksmbd/transport_tcp.c
    @@ -404,7 +404,7 @@ static int create_socket(struct interfac
    &ksmbd_socket);
    if (ret) {
    pr_err("Can't create socket for ipv4: %d\n", ret);
    - goto out_error;
    + goto out_clear;
    }

    sin.sin_family = PF_INET;
    @@ -462,6 +462,7 @@ static int create_socket(struct interfac

    out_error:
    tcp_destroy_socket(ksmbd_socket);
    +out_clear:
    iface->ksmbd_socket = NULL;
    return ret;
    }

    \
     
     \ /
      Last update: 2022-01-24 23:34    [W:4.162 / U:0.508 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site