lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0109/1039] libbpf: Fix non-C89 loop variable declaration in gen_loader.c
    Date
    From: Andrii Nakryiko <andrii@kernel.org>

    [ Upstream commit b8b5cb55f5d3f03cc1479a3768d68173a10359ad ]

    Fix the `int i` declaration inside the for statement. This is non-C89
    compliant. See [0] for user report breaking BCC build.

    [0] https://github.com/libbpf/libbpf/issues/403

    Fixes: 18f4fccbf314 ("libbpf: Update gen_loader to emit BTF_KIND_FUNC relocations")
    Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
    Link: https://lore.kernel.org/bpf/20211105191055.3324874-1-andrii@kernel.org
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/lib/bpf/gen_loader.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/lib/bpf/gen_loader.c b/tools/lib/bpf/gen_loader.c
    index 9934851ccde76..5aad39e92a7a5 100644
    --- a/tools/lib/bpf/gen_loader.c
    +++ b/tools/lib/bpf/gen_loader.c
    @@ -597,8 +597,9 @@ void bpf_gen__record_extern(struct bpf_gen *gen, const char *name, bool is_weak,
    static struct ksym_desc *get_ksym_desc(struct bpf_gen *gen, struct ksym_relo_desc *relo)
    {
    struct ksym_desc *kdesc;
    + int i;

    - for (int i = 0; i < gen->nr_ksyms; i++) {
    + for (i = 0; i < gen->nr_ksyms; i++) {
    if (!strcmp(gen->ksyms[i].name, relo->name)) {
    gen->ksyms[i].ref++;
    return &gen->ksyms[i];
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:11    [W:4.055 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site