lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0151/1039] drm/vboxvideo: fix a NULL vs IS_ERR() check
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit cebbb5c46d0cb0615fd0c62dea9b44273d0a9780 ]

    The devm_gen_pool_create() function never returns NULL, it returns
    error pointers.

    Fixes: 4cc9b565454b ("drm/vboxvideo: Use devm_gen_pool_create")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211118111233.GA1147@kili
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c
    index f28779715ccda..c9e8b3a63c621 100644
    --- a/drivers/gpu/drm/vboxvideo/vbox_main.c
    +++ b/drivers/gpu/drm/vboxvideo/vbox_main.c
    @@ -127,8 +127,8 @@ int vbox_hw_init(struct vbox_private *vbox)
    /* Create guest-heap mem-pool use 2^4 = 16 byte chunks */
    vbox->guest_pool = devm_gen_pool_create(vbox->ddev.dev, 4, -1,
    "vboxvideo-accel");
    - if (!vbox->guest_pool)
    - return -ENOMEM;
    + if (IS_ERR(vbox->guest_pool))
    + return PTR_ERR(vbox->guest_pool);

    ret = gen_pool_add_virt(vbox->guest_pool,
    (unsigned long)vbox->guest_heap,
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:3.212 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site