lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0270/1039] selftests: harness: avoid false negatives if test has no ASSERTs
    Date
    From: Jakub Kicinski <kuba@kernel.org>

    [ Upstream commit 3abedf4646fdc0036fcb8ebbc3b600667167fafe ]

    Test can fail either immediately when ASSERT() failed or at the
    end if one or more EXPECT() was not met. The exact return code
    is decided based on the number of successful ASSERT()s.

    If test has no ASSERT()s, however, the return code will be 0,
    as if the test did not fail. Start counting ASSERT()s from 1.

    Fixes: 369130b63178 ("selftests: Enhance kselftest_harness.h to print which assert failed")
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/kselftest_harness.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
    index ae0f0f33b2a6e..79a182cfa43ad 100644
    --- a/tools/testing/selftests/kselftest_harness.h
    +++ b/tools/testing/selftests/kselftest_harness.h
    @@ -969,7 +969,7 @@ void __run_test(struct __fixture_metadata *f,
    t->passed = 1;
    t->skip = 0;
    t->trigger = 0;
    - t->step = 0;
    + t->step = 1;
    t->no_print = 0;
    memset(t->results->reason, 0, sizeof(t->results->reason));

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:6.041 / U:0.348 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site