lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.16 0072/1039] virtio/virtio_mem: handle a possible NULL as a memcpy parameter
    Date
    From: Peng Hao <flyingpenghao@gmail.com>

    commit cf4a4493ff70874f8af26d75d4346c591c298e89 upstream.

    There is a check for vm->sbm.sb_states before, and it should check
    it here as well.

    Signed-off-by: Peng Hao <flyingpeng@tencent.com>
    Link: https://lore.kernel.org/r/20211222011225.40573-1-flyingpeng@tencent.com
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Fixes: 5f1f79bbc9e2 ("virtio-mem: Paravirtualized memory hotplug")
    Cc: stable@vger.kernel.org # v5.8+
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/virtio/virtio_mem.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/virtio/virtio_mem.c
    +++ b/drivers/virtio/virtio_mem.c
    @@ -592,7 +592,7 @@ static int virtio_mem_sbm_sb_states_prep
    return -ENOMEM;

    mutex_lock(&vm->hotplug_mutex);
    - if (new_bitmap)
    + if (vm->sbm.sb_states)
    memcpy(new_bitmap, vm->sbm.sb_states, old_pages * PAGE_SIZE);

    old_bitmap = vm->sbm.sb_states;

    \
     
     \ /
      Last update: 2022-01-24 23:10    [W:3.219 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site