lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 757/846] block: fix async_depth sysfs interface for mq-deadline
    Date
    From: Jens Axboe <axboe@kernel.dk>

    commit 46cdc45acb089c811d9a54fd50af33b96e5fae9d upstream.

    A previous commit added this feature, but it inadvertently used the wrong
    variable to show/store the setting from/to, victimized by copy/paste. Fix
    it up so that the async_depth sysfs interface reads and writes from the
    right setting.

    Fixes: 07757588e507 ("block/mq-deadline: Reserve 25% of scheduler tags for synchronous requests")
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=215485
    Reviewed-by: Bart Van Assche <bvanassche@acm.org>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    block/mq-deadline.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/block/mq-deadline.c
    +++ b/block/mq-deadline.c
    @@ -811,7 +811,7 @@ SHOW_JIFFIES(deadline_read_expire_show,
    SHOW_JIFFIES(deadline_write_expire_show, dd->fifo_expire[DD_WRITE]);
    SHOW_INT(deadline_writes_starved_show, dd->writes_starved);
    SHOW_INT(deadline_front_merges_show, dd->front_merges);
    -SHOW_INT(deadline_async_depth_show, dd->front_merges);
    +SHOW_INT(deadline_async_depth_show, dd->async_depth);
    SHOW_INT(deadline_fifo_batch_show, dd->fifo_batch);
    #undef SHOW_INT
    #undef SHOW_JIFFIES
    @@ -840,7 +840,7 @@ STORE_JIFFIES(deadline_read_expire_store
    STORE_JIFFIES(deadline_write_expire_store, &dd->fifo_expire[DD_WRITE], 0, INT_MAX);
    STORE_INT(deadline_writes_starved_store, &dd->writes_starved, INT_MIN, INT_MAX);
    STORE_INT(deadline_front_merges_store, &dd->front_merges, 0, 1);
    -STORE_INT(deadline_async_depth_store, &dd->front_merges, 1, INT_MAX);
    +STORE_INT(deadline_async_depth_store, &dd->async_depth, 1, INT_MAX);
    STORE_INT(deadline_fifo_batch_store, &dd->fifo_batch, 0, INT_MAX);
    #undef STORE_FUNCTION
    #undef STORE_INT

    \
     
     \ /
      Last update: 2022-01-24 22:41    [W:4.015 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site