lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 657/846] ASoC: mediatek: mt8192-mt6359: fix device_node leak
    Date
    From: Tzung-Bi Shih <tzungbi@google.com>

    [ Upstream commit 4e28491a7a198c668437f2be8a91a76aa52f20eb ]

    The of_parse_phandle() document:
    >>> Use of_node_put() on it when done.

    The driver didn't call of_node_put(). Fixes the leak.

    Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
    Link: https://lore.kernel.org/r/20211214040028.2992627-1-tzungbi@google.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c b/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c
    index a606133951b70..24a5d0adec1ba 100644
    --- a/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c
    +++ b/sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c
    @@ -1172,7 +1172,11 @@ static int mt8192_mt6359_dev_probe(struct platform_device *pdev)
    return ret;
    }

    - return devm_snd_soc_register_card(&pdev->dev, card);
    + ret = devm_snd_soc_register_card(&pdev->dev, card);
    +
    + of_node_put(platform_node);
    + of_node_put(hdmi_codec);
    + return ret;
    }

    #ifdef CONFIG_OF
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 22:41    [W:4.019 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site