lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 339/846] net/mlx5e: Dont block routes with nexthop objects in SW
    Date
    From: Maor Dickman <maord@nvidia.com>

    [ Upstream commit 9e72a55a3c9d54b38a704bb7292d984574a81d9d ]

    Routes with nexthop objects is currently not supported by multipath offload
    and any attempts to use it is blocked, however this also block adding SW
    routes with nexthop.

    Resolve this by returning NOTIFY_DONE instead of an error which will allow such
    a route to be created in SW but not offloaded.

    This fix also solve an issue which block adding such routes on different devices
    due to missing check if the route FIB device is one of multipath devices.

    Fixes: 6a87afc072c3 ("mlx5: Fail attempts to use routes with nexthop objects")
    Signed-off-by: Maor Dickman <maord@nvidia.com>
    Reviewed-by: Roi Dayan <roid@nvidia.com>
    Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
    index 21fdaf708f1fe..30282d86e6b96 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c
    @@ -268,10 +268,8 @@ static int mlx5_lag_fib_event(struct notifier_block *nb,
    fen_info = container_of(info, struct fib_entry_notifier_info,
    info);
    fi = fen_info->fi;
    - if (fi->nh) {
    - NL_SET_ERR_MSG_MOD(info->extack, "IPv4 route with nexthop objects is not supported");
    - return notifier_from_errno(-EINVAL);
    - }
    + if (fi->nh)
    + return NOTIFY_DONE;
    fib_dev = fib_info_nh(fen_info->fi, 0)->fib_nh_dev;
    if (fib_dev != ldev->pf[MLX5_LAG_P1].netdev &&
    fib_dev != ldev->pf[MLX5_LAG_P2].netdev) {
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 22:09    [W:2.276 / U:1.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site