lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 030/563] can: softing_cs: softingcs_probe(): fix memleak on registration failure
    Date
    From: Johan Hovold <johan@kernel.org>

    commit ced4913efb0acc844ed65cc01d091a85d83a2082 upstream.

    In case device registration fails during probe, the driver state and
    the embedded platform device structure needs to be freed using
    platform_device_put() to properly free all resources (e.g. the device
    name).

    Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
    Link: https://lore.kernel.org/all/20211222104843.6105-1-johan@kernel.org
    Cc: stable@vger.kernel.org # 2.6.38
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/can/softing/softing_cs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/can/softing/softing_cs.c
    +++ b/drivers/net/can/softing/softing_cs.c
    @@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia
    return 0;

    platform_failed:
    - kfree(dev);
    + platform_device_put(pdev);
    mem_failed:
    pcmcia_bad:
    pcmcia_failed:

    \
     
     \ /
      Last update: 2022-01-24 22:09    [W:4.020 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site