lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/7] drm/nouveau/device: Get right pgsize_bitmap of iommu_domain
    On Mon, Jan 24, 2022 at 03:11:00PM +0800, Lu Baolu wrote:
    > The supported page sizes of an iommu_domain are saved in the pgsize_bitmap
    > field. Retrieve the value from the right place.
    >
    > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
    > Reviewed-by: Robin Murphy <robin.murphy@arm.com>
    > Link: https://lore.kernel.org/r/20211218074546.1772553-1-baolu.lu@linux.intel.com

    Looks good:

    Reviewed-by: Christoph Hellwig <hch@lst.de>

    Wouldn't it mke sense to remove the pgsize_bitmap in struct iommu_ops
    and initialize the domain field in the domain_alloc methods? Or am I
    missing something?

    \
     
     \ /
      Last update: 2022-01-24 10:30    [W:4.156 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site