lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 295/846] crypto: octeontx2 - prevent underflow in get_cores_bmap()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 10371b6212bb682f13247733d6b76b91b2b80f9a ]

    If we're going to cap "eng_grp->g->engs_num" upper bounds then we should
    cap the lower bounds as well.

    Fixes: 43ac0b824f1c ("crypto: octeontx2 - load microcode and create engine groups")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c b/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c
    index dff34b3ec09e1..7c1b92aaab398 100644
    --- a/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c
    +++ b/drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c
    @@ -29,7 +29,8 @@ static struct otx2_cpt_bitmap get_cores_bmap(struct device *dev,
    bool found = false;
    int i;

    - if (eng_grp->g->engs_num > OTX2_CPT_MAX_ENGINES) {
    + if (eng_grp->g->engs_num < 0 ||
    + eng_grp->g->engs_num > OTX2_CPT_MAX_ENGINES) {
    dev_err(dev, "unsupported number of engines %d on octeontx2\n",
    eng_grp->g->engs_num);
    return bmap;
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 22:09    [W:2.721 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site