lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 013/563] mtd: rawnand: davinci: Rewrite function description
    Date
    From: Paul Cercueil <paul@crapouillou.net>

    commit 0697f8441faad552fbeb02d74454b5e7bcc956a2 upstream.

    The original comment that describes the function
    nand_davinci_read_page_hwecc_oob_first() is very obscure and it is hard
    to understand what it is for.

    Cc: <stable@vger.kernel.org> # v5.2
    Fixes: a0ac778eb82c ("mtd: rawnand: ingenic: Add support for the JZ4740")
    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/20211016132228.40254-3-paul@crapouillou.net
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/mtd/nand/raw/davinci_nand.c | 10 ++++------
    1 file changed, 4 insertions(+), 6 deletions(-)

    --- a/drivers/mtd/nand/raw/davinci_nand.c
    +++ b/drivers/mtd/nand/raw/davinci_nand.c
    @@ -372,17 +372,15 @@ correct:
    }

    /**
    - * nand_read_page_hwecc_oob_first - hw ecc, read oob first
    + * nand_davinci_read_page_hwecc_oob_first - Hardware ECC page read with ECC
    + * data read from OOB area
    * @chip: nand chip info structure
    * @buf: buffer to store read data
    * @oob_required: caller requires OOB data read to chip->oob_poi
    * @page: page number to read
    *
    - * Hardware ECC for large page chips, require OOB to be read first. For this
    - * ECC mode, the write_page method is re-used from ECC_HW. These methods
    - * read/write ECC from the OOB area, unlike the ECC_HW_SYNDROME support with
    - * multiple ECC steps, follows the "infix ECC" scheme and reads/writes ECC from
    - * the data area, by overwriting the NAND manufacturer bad block markings.
    + * Hardware ECC for large page chips, which requires the ECC data to be
    + * extracted from the OOB before the actual data is read.
    */
    static int nand_davinci_read_page_hwecc_oob_first(struct nand_chip *chip,
    uint8_t *buf,

    \
     
     \ /
      Last update: 2022-01-24 21:52    [W:2.268 / U:0.720 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site