lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 273/563] clk: stm32: Fix ltdcs clock turn off by clk_disable_unused() after system enter shell
    Date
    From: Dillon Min <dillon.minfei@gmail.com>

    [ Upstream commit 6fc058a72f3b7b07fc4de6d66ad1f68951b00f6e ]

    stm32's clk driver register two ltdc gate clk to clk core by
    clk_hw_register_gate() and clk_hw_register_composite()

    first: 'stm32f429_gates[]', clk name is 'ltdc', which no user to use.
    second: 'stm32f429_aux_clk[]', clk name is 'lcd-tft', used by ltdc driver

    both of them point to the same offset of stm32's RCC register. after
    kernel enter console, clk core turn off ltdc's clk as 'stm32f429_gates[]'
    is no one to use. but, actually 'stm32f429_aux_clk[]' is in use.

    stm32f469/746/769 have the same issue, fix it.

    Fixes: daf2d117cbca ("clk: stm32f4: Add lcd-tft clock")
    Link: https://lore.kernel.org/linux-arm-kernel/1590564453-24499-7-git-send-email-dillon.minfei@gmail.com/
    Link: https://lore.kernel.org/lkml/CAPTRvHkf0cK_4ZidM17rPo99gWDmxgqFt4CDUjqFFwkOeQeFDg@mail.gmail.com/
    Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
    Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
    Acked-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
    Acked-by: Stephen Boyd <sboyd@kernel.org>
    Link: https://lore.kernel.org/r/1635232282-3992-10-git-send-email-dillon.minfei@gmail.com
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/clk-stm32f4.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
    index 5c75e3d906c20..682a18b392f08 100644
    --- a/drivers/clk/clk-stm32f4.c
    +++ b/drivers/clk/clk-stm32f4.c
    @@ -129,7 +129,6 @@ static const struct stm32f4_gate_data stm32f429_gates[] __initconst = {
    { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" },
    - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
    };

    static const struct stm32f4_gate_data stm32f469_gates[] __initconst = {
    @@ -211,7 +210,6 @@ static const struct stm32f4_gate_data stm32f469_gates[] __initconst = {
    { STM32F4_RCC_APB2ENR, 20, "spi5", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" },
    - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
    };

    static const struct stm32f4_gate_data stm32f746_gates[] __initconst = {
    @@ -286,7 +284,6 @@ static const struct stm32f4_gate_data stm32f746_gates[] __initconst = {
    { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" },
    - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
    };

    static const struct stm32f4_gate_data stm32f769_gates[] __initconst = {
    @@ -364,7 +361,6 @@ static const struct stm32f4_gate_data stm32f769_gates[] __initconst = {
    { STM32F4_RCC_APB2ENR, 21, "spi6", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 22, "sai1", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 23, "sai2", "apb2_div" },
    - { STM32F4_RCC_APB2ENR, 26, "ltdc", "apb2_div" },
    { STM32F4_RCC_APB2ENR, 30, "mdio", "apb2_div" },
    };

    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 21:20    [W:2.055 / U:3.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site