lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 043/563] drm/bridge: display-connector: fix an uninitialized pointer in probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 189723fbe9aca18d6f7d638c59a40288030932b5 ]

    The "label" pointer is used for debug output. The code assumes that it
    is either NULL or valid, but it is never set to NULL. It is either
    valid or uninitialized.

    Fixes: 0c275c30176b ("drm/bridge: Add bridge driver for display connectors")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20211013080825.GE6010@kili
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/bridge/display-connector.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c
    index 4d278573cdb99..544a47335cac4 100644
    --- a/drivers/gpu/drm/bridge/display-connector.c
    +++ b/drivers/gpu/drm/bridge/display-connector.c
    @@ -104,7 +104,7 @@ static int display_connector_probe(struct platform_device *pdev)
    {
    struct display_connector *conn;
    unsigned int type;
    - const char *label;
    + const char *label = NULL;
    int ret;

    conn = devm_kzalloc(&pdev->dev, sizeof(*conn), GFP_KERNEL);
    --
    2.34.1


    \
     
     \ /
      Last update: 2022-01-24 20:54    [W:3.503 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site