lkml.org 
[lkml]   [2022]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 00/20] tcp: Initial support for RFC5925 auth option
On Mon, 24 Jan 2022 14:12:46 +0200 Leonard Crestez wrote:
> This is similar to TCP-MD5 in functionality but it's sufficiently
> different that packet formats and interfaces are incompatible.
> Compared to TCP-MD5 more algorithms are supported and multiple keys
> can be used on the same connection but there is still no negotiation
> mechanism.
>
> [...]

Could you make sure that each individual patch builds cleanly with W=1
C=1? There is a bunch of missing "static" and unused function warnings
in the first few patches. I presume they are made moot by later patches
but with kernel defaulting to Werror now it's a dangerous game to play,
we don't want to break bisection.

Also I spotted this:

include/net/tcp_authopt.h:59: warning: Function parameter or member 'prefixlen' not described in 'tcp_authopt_key_info'

\
 
 \ /
  Last update: 2022-01-24 19:42    [W:0.016 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site