lkml.org 
[lkml]   [2022]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] Fixed: Misaligned memory access. Fixed pointer comparison.
From
No.  It only uses tabs.  The previous version used spaces.
Make sure that you are not looking at a line with a '-'.
The only place that spaces, perhaps combined with tabs, appear
at the start of a line in my patch is to align the '*' character
for a multi-line comment. In this case, tab(s) are followed by
a single space for alignment. I believe this is correct per
the coding style. If I am wrong, please let me know.

----Michael

On 1/23/22 08:31, David Laight wrote:

> From: michael@michaelkloos.com
>> Sent: 23 January 2022 03:45
>>
>> Rewrote the riscv memmove() assembly implementation. The
>> previous implementation did not check memory alignment and it
>> compared 2 pointers with a signed comparison. The misaligned
>> memory access would cause the kernel to crash on systems that
>> did not emulate it in firmware and did not support it in hardware.
>> Firmware emulation is slow and may not exist. Additionally,
>> hardware support may not exist and would likely still run slower
>> than aligned accesses even if it did. The RISC-V spec does not
>> guarantee that support for misaligned memory accesses will exist.
>> It should not be depended on.
> ...
>
> From the way my email client display the patch I think it is
> using both tabs and spaces for indentation.
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>

\
 
 \ /
  Last update: 2022-01-23 17:53    [W:0.117 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site