lkml.org 
[lkml]   [2022]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] habanalabs: silence an uninitialized variable warning
    On Tue, Jan 11, 2022 at 9:17 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
    >
    > Smatch warns that:
    >
    > drivers/misc/habanalabs/common/command_buffer.c:471 hl_cb_ioctl()
    > error: uninitialized symbol 'device_va'.
    >
    > Which is true, but harmless. Anyway, it's easy to silence this by
    > adding a error check.
    >
    > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    > ---
    > drivers/misc/habanalabs/common/command_buffer.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/drivers/misc/habanalabs/common/command_buffer.c b/drivers/misc/habanalabs/common/command_buffer.c
    > index 3c0ae07a2d80..b9483a3cee91 100644
    > --- a/drivers/misc/habanalabs/common/command_buffer.c
    > +++ b/drivers/misc/habanalabs/common/command_buffer.c
    > @@ -464,6 +464,8 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data)
    > args->in.flags,
    > &usage_cnt,
    > &device_va);
    > + if (rc)
    > + break;
    >
    > memset(&args->out, 0, sizeof(args->out));
    >
    > --
    > 2.20.1
    >

    Thanks!
    Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
    Applied to -next.

    \
     
     \ /
      Last update: 2022-01-23 15:41    [W:3.484 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site