Messages in this thread Patch in this message | | | From | Chen-Yu Tsai <> | Subject | [PATCH 23/31] clk: mediatek: mux: Reverse check for existing clk to reduce nesting level | Date | Sat, 22 Jan 2022 17:17:23 +0800 |
| |
The clk registration code here currently does:
if (IS_ERR_OR_NULL(clk_data->clks[mux->id])) { ... do clk registration ... }
This extra level of nesting wastes screen real estate.
Reduce the nesting level by reversing the conditional shown above. Other than that, functionality is not changed.
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- drivers/clk/mediatek/clk-mux.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/mediatek/clk-mux.c b/drivers/clk/mediatek/clk-mux.c index 01af6a52711a..70aa42144632 100644 --- a/drivers/clk/mediatek/clk-mux.c +++ b/drivers/clk/mediatek/clk-mux.c @@ -208,16 +208,17 @@ int mtk_clk_register_muxes(const struct mtk_mux *muxes, for (i = 0; i < num; i++) { const struct mtk_mux *mux = &muxes[i]; - if (IS_ERR_OR_NULL(clk_data->clks[mux->id])) { - clk = mtk_clk_register_mux(mux, regmap, lock); + if (!IS_ERR_OR_NULL(clk_data->clks[mux->id])) + continue; - if (IS_ERR(clk)) { - pr_err("Failed to register clk %s: %pe\n", mux->name, clk); - continue; - } + clk = mtk_clk_register_mux(mux, regmap, lock); - clk_data->clks[mux->id] = clk; + if (IS_ERR(clk)) { + pr_err("Failed to register clk %s: %pe\n", mux->name, clk); + continue; } + + clk_data->clks[mux->id] = clk; } return 0; -- 2.35.0.rc0.227.g00780c9af4-goog
| |