Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 21 Jan 2022 10:26:10 +0100 | Subject | Re: [RFC PATCH v2 1/4] media: dt-bindings: media: Document RZ/G2L CSI-2 block |
| |
Hi Prabhakar,
On Fri, Jan 21, 2022 at 2:06 AM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Document the CSI-2 block which is part of CRU found in Renesas > RZ/G2L SoC. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thanks for your patch!
> --- > Hi Geert/All, > > vclk and pclk clocks are shared with CRU both CSI and CRU driver are using > pm_runtime. pclk clock is necessary for register access where as vclk clock > is only used for calculations. So would you suggest passing vclk as part of
What do you mean by "calculations"? The bindings say this is the main clock?
> clocks (as currently implemented) or pass the vclk clock rate as a dt property.
Please do not specify clock rates in DT, but always pass clock specifiers instead. The clock subsystem handles sharing of clocks just fine.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |